remove dependency on rmw_implementation #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirk-thomas
changed the title
ivanpauno
approved these changes
Apr 9, 2020
dirk-thomas
changed the title
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
dirk-thomas
force-pushed
the
dirk-thomas/avoid-generators-depend-on-rmw
branch
from
8d82073
to
e46ff4e
Compare
… variable passed as an argument Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
dirk-thomas
commented
Apr 10, 2020
| set(_typesupport_impls "") | ||
| call_for_each_rmw_implementation(accumulate_typesupports) | ||
| foreach(_typesupport_impl ${_typesupport_impls}) | ||
| list_append_unique(TYPESUPPORT_IMPLS ${_typesupport_impl}) |
There was a problem hiding this comment.
The previous logic was broken. The variable which name is passed in TYPESUPPORT_IMPLS is never set by the macro. This only happened to work if the caller expected the result in _typesupport_impls. 🤯
There was a problem hiding this comment.
Oh, cmake macros are really tricky.
delete-merged-branch
bot
deleted the
dirk-thomas/avoid-generators-depend-on-rmw
branch
jacobperron
reviewed
Apr 30, 2020
| @@ -36,8 +35,6 @@ | |||
| <test_depend>python3-pytest</test_depend> | |||
| <test_depend>python_cmake_module</test_depend> | |||
| <test_depend>rmw</test_depend> | |||
| <test_depend>rmw_implementation</test_depend> | |||
There was a problem hiding this comment.
I believe this change led to a failure on the binary job. We're generating messages for tests, but there's no C typesupport available (previously transitively brought in by rmw_implementation).
Here is a proposed fix: #110
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for ros2/rmw_dds_common#12